Summary

Make the mailing list for a group optional

Review Request #66 — Created June 16, 2007 and submitted

Information

Owner

david

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A few people have requested that groups could exist without a
mailing list to send to, and have it so relevant review requests
and reviews get e-mailed to any individual subscribers instead
of to the list.

This change (hopefully) does that.  It should be a fairly
self-explanatory patch.

Testing Done

Fixed up unit tests for new API and ran them.  The actual code
path for groups without mailing lists hasn't been tested, since
I'm not sure how to modify the fixture to add relevant test data.

Ship it!

Thanks for this change -- I had thought it a little weird that one could be a member of a group but not receive emails for that group (if not on the mailing list).  Sending to all group members fits my mindset a lot better.

trunk/reviewboard/reviews/email.py (Diff revision 1)

As an aside, the recipient_table -> recipient_list could be better expressed with a set().

Ship it!

```
Looks good to me.
```

Ship it!

Thanks a lot. This looks exactly like what I was looking for.