• 
      

    Adding documentation for AdminWidgetHook

    Review Request #6597 — Created Nov. 16, 2014 and submitted

    Information

    Review Board
    master
    f077343...

    Reviewers

    Provides documentation and sample code for the newly created AdminWidgetHook.

    
     
    Description From Last Updated

    How about "allows extensions to register new widgets for the administration dashboard."

    daviddavid

    Can you add the ugettext_lazy import to the list of imports so that _() is defined?

    daviddavid

    I think we're targetting this work for 2.1.

    chipx86chipx86

    Make sure the trailing whitespace is removed.

    chipx86chipx86

    No blank line here, since from the extension's point of view, reviewboard is a third-party module.

    chipx86chipx86

    Two blank lines.

    chipx86chipx86
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          docs/manual/extending/extensions/hooks/index.rst
          docs/manual/extending/extensions/hooks/admin-widget-hook.rst
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          docs/manual/extending/extensions/hooks/index.rst
          docs/manual/extending/extensions/hooks/admin-widget-hook.rst
      
      
    2. 
        
    david
    1. 
        
    2. Show all issues

      How about "allows extensions to register new widgets for the administration dashboard."

    3. Show all issues

      Can you add the ugettext_lazy import to the list of imports so that _() is defined?

    4. 
        
    justy777
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          docs/manual/extending/extensions/hooks/index.rst
          docs/manual/extending/extensions/hooks/admin-widget-hook.rst
      
      
      
      Tool: Pyflakes
      Ignored Files:
          docs/manual/extending/extensions/hooks/index.rst
          docs/manual/extending/extensions/hooks/admin-widget-hook.rst
      
      
    2. 
        
    chipx86
    1. 
        
    2. Show all issues

      I think we're targetting this work for 2.1.

    3. Show all issues

      Make sure the trailing whitespace is removed.

    4. Show all issues

      No blank line here, since from the extension's point of view, reviewboard is a third-party module.

    5. Show all issues

      Two blank lines.

    6. 
        
    justy777
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          docs/manual/extending/extensions/hooks/index.rst
          docs/manual/extending/extensions/hooks/admin-widget-hook.rst
      
      
      
      Tool: Pyflakes
      Ignored Files:
          docs/manual/extending/extensions/hooks/index.rst
          docs/manual/extending/extensions/hooks/admin-widget-hook.rst
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    justy777
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (492a420)