Fix some text-related issues in the new review dialog.

Review Request #6586 — Created Nov. 14, 2014 and submitted — Latest diff uploaded

Information

Review Board
master
d525a4a...

Reviewers

The new review dialog had some quirks with the new Markdown code.
Publishing would end up saving HTML-formatted versions of the text,
and saving then editing the body top/bottom text would result in an
empty field.

The HTML-formatting issue was due to the way in which we load and then
save the review. Upon loading, we'd force text to HTML, which would then
be saved back out when doing the publish. We had similar issues with the
Ship It and Open An Issue checkboxes.

This was fixed by using the new fine-grained saving, making sure to only
save the fields we care about. I also made some fixes to ensure that
toggling these checkboxes wouldn't cause the stored text to be displayed
as plain text, which was caused by not setting force-text-type and
include-text-types on all requests.

The "empty field on edit" issue was due to using an incorrect variable
when loading the raw value for a field after save. We now use the
correct value.

Tested saving and editing fields, ensuring that the previously saved
raw text loaded correctly.

Tried toggling the Ship It, Issue Opened, and publishing. Didn't see any
incorrectly formatted text stored on the server, or any text rendered
incorrectly.