• 
      

    Fix using the search field to jump to a review request by ID.

    Review Request #6565 — Created Nov. 7, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    a8d13a6...

    Reviewers

    In Review Board 1.7.x, it was possible to enter an ID in the search
    field and, if search was enabled for that installation, go directly to
    the review request page.

    The search rewrite in 2.0 lost this ability. This change adds it back
    through the same mechanism.

    We probably want to support this functionality directly in the quick
    search widget in the future, so that it would work without having to
    have full-on search enabled. In the meantime, however, this at least
    fixes this particular regression.

    It's also worth noting that in 1.7.x, this was broken with Local Sites,
    as it tried to use database IDs and not display IDs. This is fixed
    properly for 2.0.

    Enabled search and typed an ID. Got redirected to the correct review
    request.

    Description From Last Updated

    list comprehension redefines 'file_attachment' from line 578

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
      
      
    2. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
       list comprehension redefines 'file_attachment' from line 578
      
    3. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (4f9974f)