• 
      

    Swap the order in which attachments are made inactive.

    Review Request #6564 — Created Nov. 6, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    cb62c3e...

    Reviewers

    The code for marking file attachments as inactive would first remove
    from the list of active attachments and then add to the list of
    inactive attachments. If anything went wrong in-between, the attachment
    could go missing.

    It might still be bad for an attachment to be in both locations, but at
    least now it shouldn't out-right disappear and break things (in the same
    way).

    Unit tests pass.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/resources/base_file_attachment.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/resources/base_file_attachment.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (be9a0d9)