Don't create a draft review if nothing is changed in the "Review" dialog.

Review Request #6537 — Created Oct. 30, 2014 and submitted

Information

Review Board
master
a5aad2a...

Reviewers

With the rewrite of the "Review" dialog, it was possible to create a draft
review by opening the dialog and closing it without making any changes. This
change adds some logic to avoid saving the review model if there haven't been
any modifications.

  • Without an existing draft review, opened the dialog and closed it. Saw no
    draft banner.
  • Without an existing draft review, opened the dialog, set "Ship it", and
    closed it. Saw a draft banner.
  • Without an existing draft review, opened the dialog, put some text in the
    body_top editor, and closed it. Saw a draft banner.
  • With an existing draft review, opened the dialog and closed it. Saw the draft
    banner stayed present.
  • Ran js-tests.
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (3ed91ad)