Fix JavaScript unit test failures from the Markdown work.

Review Request #6534 — Created Oct. 29, 2014 and submitted

Information

Review Board
release-2.0.x
06be989...

Reviewers

The recent Markdown work introduced some JavaScript unit test failures.
Most weren't a big deal, but one caused a lot of problems.

The recent change to ResourceCollection designed to prevent pollution of
options.data didn't end up setting options.data back to a value, causing
all query parameters to drop.

This fixes all the failures, resulting in 100% of tests passing on
Firefox and Chrome.

Ran the test suite on Chrome and Firefox. All tests now pass.

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/resources/collections/resourceCollection.js
        reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
        reviewboard/static/rb/js/views/tests/reviewDialogViewTests.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/resources/collections/resourceCollection.js
        reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
        reviewboard/static/rb/js/views/tests/reviewDialogViewTests.js
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (bcde650)