• 
      

    Factor in the Markdown default in one more location.

    Review Request #6523 — Created Oct. 29, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    843f537...

    Reviewers

    The previous change to factor in Markdown defaults didn't update one
    critical function. This function determines if Markdown should be used
    when determining CSS classes in a couple locations, and when determining
    if plain text should be escaped for Markdown.

    Unit tests pass.

    Checked that the result of the function was correct for a user's preference.

    Description From Last Updated

    No reason for this blank line.

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/markdown_utils.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/markdown_utils.py
      
      
    2. 
        
    david
    1. 
        
    2. reviewboard/reviews/markdown_utils.py (Diff revision 1)
       
       
      Show all issues

      No reason for this blank line.

      1. I know it may seem silly, but I always like to separate my variable declarations/logic from my returns. I'm generally pretty consistent in that, and it's like that throughout most of the codebase.

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to markdown-redesign (c07cde6)