Summary

add --guess-branch support (clearcase implementation only)

Review Request #6515 — Created Oct. 28, 2014 and discarded Oct. 20, 2015, 4:21 p.m.

Information

Owner

delyn

Repository

RBTools

Branch

release-0.6.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Implementation provided when revisions are UCM ClearCase activity and base ClearCase branch (brtype:)

cf this thread
https://groups.google.com/forum/#!topic/reviewboard-dev/gGWV2DQhgZ4

Testing Done

can post successfully this request with --guess-branch=no

can post successfully review request --guess-branch=yes from clearcase scm with revisions brtype:branch against reviewboard server 1.7.6 (current branch filled)

can post successfully review request --guess-branch=yes from ucm clearcase activity with revisions activity:activity against reviewboard server 1.7.6 (deliver stream filled)

Issues

Description	From	Last Updated
Col: 41 E231 missing whitespace after ','	reviewbot	Oct. 28, 2014, 10:53 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 10:54 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 10:54 a.m.
(reply to myself as a reminder) should raise "NotImplementedError" so that this exception can be caught as expected when using …	DE delyn	Jan. 14, 2015, 7:12 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py

rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 41
 E231 missing whitespace after ','
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Change Summary:

fix typo reported by reviewbot

Description:

		Implementation provided when revisions are UCM ClearCase activity and base ClearCase branch (brtype:)

		cf this thread
		https://groups.google.com/forum/#!topic/reviewboard-dev/gGWV2DQhgZ4

Commit:

e340e97bc84fb40dbee4422e02f95c6005380efc

1037744e529f45c70d7d56d867bc8b55a5c2e75a

Diff:

Revision 2 (+160 -4)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/clearcase.py
	rbtools/commands/post.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py

rbtools/clients/clearcase.py (Diff revision 2)

The issue has been resolved. Show all issues

(reply to myself as a reminder) should raise "NotImplementedError" so that this exception can be caught as expected when using base clearcase lbtype comparison

Change Summary:

raise NotImplementedError when guessing branch is not supported. Indeed base clearcase does not support guessing branch unless using brtype option

Diff:

Revision 3 (+161 -4)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/clearcase.py
	rbtools/commands/post.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py

Status:: Discarded