• 
      

    Only set a DB index for ReviewRequest.summary.

    Review Request #6498 — Created Oct. 23, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    9b8ea77...

    Reviewers

    The previous change I had for adding an index for search added it in
    BaseReviewRequestDetails. While we didn't need it for drafts, I figured
    it didn't hurt.

    However, it exposed a bug in django-evolution, where, presumably due to
    the base class, applying the change to ReviewRequest's signature also
    affected ReviewRequestDraft's.

    I don't have a fix for that yet in django-evolution, so for now, I'm
    splitting that field out and turning indexing on only for
    ReviewRequest.summary.

    Was able to successfully run an evolution on an older database.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/models/base_review_request_details.py
          reviewboard/reviews/evolutions/review_request_summary_index.py
          reviewboard/reviews/models/review_request_draft.py
          reviewboard/reviews/models/review_request.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/models/base_review_request_details.py
          reviewboard/reviews/evolutions/review_request_summary_index.py
          reviewboard/reviews/models/review_request_draft.py
          reviewboard/reviews/models/review_request.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (7e6a147)