Fix dirty calculation on cancellation of an inline editor.

Review Request #6442 — Created Oct. 14, 2014 and submitted

Information

Djblets
release-0.8.x
6d4ca78...

Reviewers

cancel() was updating the dirty state in order to determine if it should
show a prompt. However, unlike save(), we don't want to unconditionally
do this, as we can end up in a state where the initial and current
fields don't match, but the user hasn't actually changed anything
(depending on the initial value set in an edited field).

We now call dirty() instead, which will properly handle forcing a
computation only if necessary.

Unit tests pass.

No longer saw a prompt on cancel for Markdown fields.

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/jquery.gravy.inlineEditor.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/jquery.gravy.inlineEditor.js
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (5713ed6)