• 
      

    Fix dirty state calculation in inlineEditor.

    Review Request #6433 — Created Oct. 12, 2014 and submitted

    Information

    Djblets
    release-0.8.x
    35240f6...

    Reviewers

    The recent optimization for inlineEditor resulted in fields that could
    not be saved, due to the dirty state not yet being updated.

    Now, we force a calculation when we need the value. It will result in an
    extra calculation, since a _.throttle can't be canceled, but it
    shouldn't have any noticeable impact, as it occurs only on save/cancel
    or when specifically requesting the dirty state.

    Tested saving and canceling fields. Didn't have any problems.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (d0103be)