- Testing Done:
-
Wrote Markdown text in the Submitted and Discard banner text fields.
Reloaded and saw the rendered markdown both in the banner and the change box. Clicked the box and saw that it properly loaded the raw Markdown text (which it wasn't doing before this change). Did the same for standard draft banners and saw the proper rendered text.
Tested that loading the unrendered text worked. + + Unit tests pass.
Support Markdown in the Submitted/Discarded text fields.
Review Request #6409 — Created Oct. 6, 2014 and submitted
We didn't have any proper support for Markdown text in the
Submitted/Discarded text fields before, due to lack of proper plumbing
in the API and in ReviewRequest.close().Now it's possible to write Markdown and save it. It will render both in
the banner and in the change description box.
Wrote Markdown text in the Submitted and Discard banner text fields.
Reloaded and saw the rendered markdown both in the banner and the change
box. Clicked the box and saw that it properly loaded the raw Markdown
text (which it wasn't doing before this change).Did the same for standard draft banners and saw the proper rendered text.
Tested that loading the unrendered text worked.Unit tests pass.
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/review_request.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/review_request.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/views/reviewRequestEditorView.js