Summary

[WIP] `rbt post` command uses API's DiffValidation endpoint before upload

Review Request #6404 — Created Oct. 5, 2014 and discarded Oct. 6, 2014, 1:03 a.m.

Information

Owner

asalahli

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Before updating a review request or creating a new one, `rbt post`
command validates the diff file and terminates if it does not pass
validation. This prevents the command from creating empty review
requests when the supplied diff file is invalid.

Testing Done

Nothing yet.

Issues

Description	From	Last Updated
Col: 21 E128 continuation line under-indented for visual indent	reviewbot	Oct. 5, 2014, 11:05 a.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Oct. 5, 2014, 11:05 a.m.

Fix it!

Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py
    rbtools/api/resource.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py
    rbtools/api/resource.py

rbtools/api/resource.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 21
 E128 continuation line under-indented for visual indent
```
rbtools/api/resource.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```

Status:: Discarded

rbtools/api/resource.py (Diff revision 1)

rbtools/api/resource.py (Diff revision 1)