• 
      

    Add an installer for MacOS X.

    Review Request #6401 — Created Oct. 4, 2014 and submitted

    Information

    RBTools
    release-0.6.x
    9d77eb5...

    Reviewers

    This adds an installer for RBTools on MacOS X, which bundles the command
    line utilities and the modules for both Python 2.6 and 2.7, both of
    which are standard on modern versions of MacOS X.

    The installer is built with the build-mpkg.sh script, which will
    generate the appropriate builds for Python 2.6 and 2.7 versions, and
    assemble all the pieces into a standard .pkg file that can be
    distributed.

    Currently, attempting to install this package will result in a complaint
    about it not being signed, making it difficult and scary to install.
    This will be fixed when we have the ability to sign the package, which
    will happen prior to the package's official release.

    Built an installer and tested it in a VM. Successfully installed a build
    of RBTools, and had access to the Python modules from both Python 2.6 and 2.7.

    I was able to build this inside and outside of a virtualenv, without any path
    distortion.


    Description From Last Updated

    .tiff and image/png? Wat?

    daviddavid

    Is it possible to skip this page entirely? The MIT license isn't something that end-users have to agree to.

    daviddavid

    This should be 2007-2014

    daviddavid
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          contrib/installers/macosx/resources/background@2x.tiff
          contrib/installers/macosx/resources/background.tiff
          contrib/installers/macosx/resources/license.html
          contrib/installers/macosx/build-mpkg.sh
          contrib/installers/macosx/resources/welcome.html
          contrib/installers/macosx/resources/conclusion.html
          contrib/installers/macosx/distribution.xml
      
      
      
      Tool: Pyflakes
      Ignored Files:
          contrib/installers/macosx/resources/background@2x.tiff
          contrib/installers/macosx/resources/background.tiff
          contrib/installers/macosx/resources/license.html
          contrib/installers/macosx/build-mpkg.sh
          contrib/installers/macosx/resources/welcome.html
          contrib/installers/macosx/resources/conclusion.html
          contrib/installers/macosx/distribution.xml
      
      
    2. 
        
    david
    1. 
        
    2. contrib/installers/macosx/distribution.xml (Diff revision 1)
       
       
       
      Show all issues

      .tiff and image/png? Wat?

    3. Show all issues

      Is it possible to skip this page entirely? The MIT license isn't something that end-users have to agree to.

    4. Show all issues

      This should be 2007-2014

      1. This file is gone now.

    5. 
        
    chipx86
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          contrib/installers/macosx/resources/background@2x.tiff
          contrib/installers/macosx/resources/background.tiff
          contrib/installers/macosx/build-mpkg.sh
          contrib/installers/macosx/resources/welcome.html
          contrib/installers/macosx/resources/conclusion.html
          contrib/installers/macosx/distribution.xml
      
      
      
      Tool: Pyflakes
      Ignored Files:
          contrib/installers/macosx/resources/background@2x.tiff
          contrib/installers/macosx/resources/background.tiff
          contrib/installers/macosx/build-mpkg.sh
          contrib/installers/macosx/resources/welcome.html
          contrib/installers/macosx/resources/conclusion.html
          contrib/installers/macosx/distribution.xml
      
      
    2. 
        
    david
    1. 
        
    2. Just curious, does this framework work with .png?

      1. In theory yes. In practice, not so well.

        Turns out that it really wants a tiff, for Retina usage. It's layered, so there's a tiff for non-Retina, and a tiff for Retina. These get combined into a single tiff that the installer can use for either.

        The installer will not look for a @2x PNG.

        If you do try to use PNGs, the installer, on some versions of OSX, will do some odd stretchy things to it.

    3. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (33e6cfb)