Summary

Git client: properly handle deleted files when making SVN-compatible diff

Review Request #6396 — Created Oct. 2, 2014 and submitted Oct. 3, 2014, 4:59 p.m.

Information

Owner

jrmrjnck

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

d0a7790...

Reviewers

Groups

rbtools

People

Description

When deleting a file, git-diff outputs "+++ /dev/null" and "deleted file mode", neither of which are understood by SVN. Rather, SVN expects the new filename to be the same as the deleted one. This is important when doing file renames or deletions when using git-svn.

Testing Done

Successfully used this code to post a review for a basic set of file renames (~10 files). Posted to RB 1.6 and it seemed to be happy.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Oct. 2, 2014, 9:13 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/git.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/git.py

rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```

Change Summary:

Fix too long line

Commit:

e1164467d0ebd592eaa229a6aa2a5e948656094b

d0a77909cd646b7681b5fa9bc1d2af36a73f97c3

Diff:

Revision 2 (+6 -3)

Show changes

rbtools/clients/git.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/git.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/git.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.6.x (ffba29b)

rbtools/clients/git.py (Diff revision 1)