This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-2.0.x (e3de9ec)

Summary

Add an is_enabled_for mechanism for NavigationBarHook.

Review Request #6390 — Created Oct. 1, 2014 and submitted 10 years, 8 months ago

Information

Owner

david*

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

a2f1747...

Reviewers

Groups

reviewboard

People

Description*

This adds a way for NavigationBarHooks to be enabled/disabled per-user. This is
done by adding a new, optional is_enabled_for flag to the constructor, which is
a callable that returns either True or False.

Testing Done


Ran unit tests.
Used this in an extension.

Issues

Description	From	Last Updated
Why isn't this just in the argument list?	chipx86	10 years, 8 months ago
This should probably go in the docstring.	chipx86	10 years, 8 months ago
There are no open issues

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py

reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Why isn't this just in the argument list?
```
1. david 10 years, 8 months ago
  I don't even know.

Commit:

9bcf0a0f27e94fcd91186f95a173884d4013c7a9

a2f17479eef33939b6d5ef576621aa221d689e04

Diff:

Revision 2 (+12 -2)

Show changes

reviewboard/extensions/hooks.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py

Ship it!

reviewboard/extensions/hooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This should probably go in the docstring.
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (e3de9ec)