• 
      

    Add exclude files support to the Perforce SCMClient.

    Review Request #6376 — Created Sept. 26, 2014 and submitted

    Information

    RBTools
    master
    48f5441...

    Reviewers

    The Perforce SCMClient now supports the -X flag for diff and post
    operations. The -X parameter specifies a pattern to match against.
    To specify a pattern against a depot, use -X //depot/... and to
    specify a relative (to the current working directory) pattern, use
    -X pattern. A pattern that beings with a single slash is
    interpreted as an absolute path.

    Generated diffs via rbt diff -X that excluded files. This was tested
    using numbered changesets (both submitted and pending) and the default
    changeset (i.e., open files)

    Description From Last Updated

    Col: 18 E127 continuation line over-indented for visual indent

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Remove this line.

    daviddavid

    Leftover debugging code?

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      
    2. 
        
    brennie
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
    2. 
        
    david
    1. Would it be possible to have it so that if an exclude pattern starts with "//", treat it as a depot path, and if it doesn't, treat it as a local (relative) path?

      1. Fixed in latest diff.

    2. 
        
    brennie
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
    2. rbtools/clients/perforce.py (Diff revision 3)
       
       
      Show all issues
      Col: 18
       E127 continuation line over-indented for visual indent
      
    3. rbtools/clients/perforce.py (Diff revision 3)
       
       
      Show all issues
      Col: 1
       W391 blank line at end of file
      
    4. 
        
    brennie
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
      
      Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
    2. 
        
    david
    1. Looking pretty good! Just a couple trivial comments.

    2. rbtools/clients/perforce.py (Diff revision 4)
       
       
      Show all issues

      Remove this line.

    3. rbtools/clients/perforce.py (Diff revision 4)
       
       
      Show all issues

      Leftover debugging code?

    4. 
        
    brennie
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
    2. 
        
    brennie
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
    2. 
        
    brennie
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/post.rst
          docs/rbtools/rbt/commands/diff.rst
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.6.x (144ecf2)