Refactor revision selectors for future file attachment support.

 






 

 


  Review Request #6342
  —
  Created Sept. 19, 2014 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 









 
 

  df43e22...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change refactors the DiffRevisionSelectorView control to abstract out

common functionality into a new RevisionSelectorView abstract base class. This

is then inherited by the existing DiffRevisionSelectorView and a new

FileAttachmentRevisionSelectorView.

 








  


 
 

  
Tested the various behavior in the DiffRevisionSelectorView.

FileAttachmentRevisionSelectorView is currently un-tested.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/diffviewer/views/diffRevisionLabelView.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/pages/views/diffViewerPageView.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/fileAttachmentRevisionSelectorView.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/revisionSelectorView.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...