Summary

Refactor revision selectors for future file attachment support.

Review Request #6342 — Created Sept. 19, 2014 and submitted Sept. 20, 2014, 11:10 a.m. — Latest diff uploaded Sept. 19, 2014, 11:08 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

df43e22...

Reviewers

Groups

reviewboard

People

Description

This change refactors the DiffRevisionSelectorView control to abstract out
common functionality into a new RevisionSelectorView abstract base class. This
is then inherited by the existing DiffRevisionSelectorView and a new
FileAttachmentRevisionSelectorView.

Testing Done

Tested the various behavior in the DiffRevisionSelectorView.
FileAttachmentRevisionSelectorView is currently un-tested.