fixing Issue 3300:Add a confirmation when discarding a pending review
Review Request #6341 — Created Sept. 19, 2014 and submitted — Latest diff uploaded
When a user has a draft review, and opens up the "Edit Review" box to finalize their comments and publish, the "Discard Review" command did not confirm at all. Now it gives a prompt to discard or cancel.
Visually Tested (In Chome, and Firefox).
Wrote a review; both pressing and not pressing 'ok' under the comment.
Case 1: Clicking Discard Review, then clicking cancel. It takes away the prompt.
Case 2: Clicking Discard Review, then clicking discard. Discards the review and goes back to the review request.
Diff Revision 3
This is not the most recent revision of the diff. The latest diff is revision 9. See what's changed.
orig
1
2
3
4
5
6
7
8
9
| reviewboard/static/rb/js/views/draftReviewBannerView.js |
|---|
| reviewboard/static/rb/js/views/reviewDialogView.js |
|---|