• 
      

    Fixed registration email false positives (issue no. 3438)

    Review Request #6330 — Created Sept. 16, 2014 and discarded — Latest diff uploaded

    Information

    Review Board
    master

    Reviewers

    Fixed the issue: https://code.google.com/p/reviewboard/issues/detail?id=3438

    The fix itself is actually depends on the implementation of
    djblets/auth/views.py:register(). Currently this fix seems
    to be the only way of checking if registration was successful.
    But, I'm not sure if it is the best way to do it. I think
    djblets/auth/views.py:register() should have a way of reporting
    the status of registration to the caller.

    Unit tests pass.

    Did manual testing to make sure the emails only get sent after successful registration.

    No automated testing done.