Fixed registration email false positives (issue no. 3438)
Review Request #6330 — Created Sept. 16, 2014 and discarded
Fixed the issue: https://code.google.com/p/reviewboard/issues/detail?id=3438
The fix itself is actually depends on the implementation of
djblets/auth/views.py:register(). Currently this fix seems
to be the only way of checking if registration was successful.
But, I'm not sure if it is the best way to do it. I think
djblets/auth/views.py:register()should have a way of reporting
the status of registration to the caller.
Unit tests pass.
Did manual testing to make sure the emails only get sent after successful registration.
No automated testing done.
| Description | From | Last Updated |
|---|---|---|
|
Col: 1 W293 blank line contains whitespace |
 reviewbot
|
-
As you mention, this should probably be done another way. My suggestion would be to change the djblets view to emit a signal when a new user is registered, and then we can get rid of the e-mail code from here and have a signal listener (in reviewboard/notifications) send it.
Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/views.py Tool: Pyflakes Processed Files: reviewboard/accounts/views.py