• 
      

    Don't crash the dashboard if a bug can't be linked.

    Review Request #6329 — Created Sept. 16, 2014 and submitted

    Information

    Review Board
    master
    840bafe...

    Reviewers

    In the case where the bugs field contains characters which aren't valid in the
    URL, creating the link would fail with NoReverseMatch. In the case discovered,
    a URL was entered in the field instead of a bug number.

    This change fixes it so that if any URLs don't reverse, we just stick the text
    in without a link.

    • Set up a reproduction case. Before the change, my dashboard gives a
      traceback. After, I see my dashboard correctly.
    • Ran unit tests.
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/datagrids/columns.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/datagrids/columns.py
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (0f6fe84)