Summary

Fix some Python 3.x issues that have slipped in.

Review Request #6327 — Created Sept. 15, 2014 and submitted Sept. 17, 2014, 2:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

b247702...

Reviewers

Groups

reviewboard

People

Description

Since I initially did our 3.x porting, a few things have slipped in (mostly
merges from the 1.7.x branch, which doesn't have the same requirements).

Testing Done

Ran 2to3 and saw that the only reported issues are expected (presence of
__future__ stuff, and code where we use six to update something but 2to3 can't
tell the difference).

Issues

Description	From	Last Updated
These should probably be ported to release-1.7.x. I don't have any clue why StandardError is being raised here.	chipx86	Sept. 16, 2014, 4:43 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/attachments/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/managers.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/attachments/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/managers.py

Ship it!

reviewboard/extensions/tests.py (Diff revision 1)

The issue has been dropped. Show all issues

These should probably be ported to release-1.7.x. I don't have any clue why StandardError is being raised here.

david Sept. 16, 2014, 4:43 p.m.
```
This code doesn't exist in 1.7.x
```
chipx86 Sept. 16, 2014, 4:51 p.m.
```
Oh right.. duh..
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (2f01585)