Add customized instructions for configuring webhooks for repositories.

Review Request #6314 — Created Sept. 11, 2014 and submitted

Information

Review Board
release-2.0.x
8e0d34b...

Reviewers

HostingService subclasses can now provide a set of instructions for
configuring any incoming webhooks that their repositories support. This
is done by setting has_repository_hook_instructions = True on the
subclass and then overriding get_repository_hook_instructions().

Any repositories whose HostingServices support hook instructions will
have a "[Hooks]" link in the repository list page in the admin UI.
Clicking this will pop up a modal dialog with the instructions.

Currently, this is only implemented for GitHub. The GitHub instructions
explain the close-submitted webhook, provide examples, link to the page
for adding a new webhook for that repository, and provide all the fields
to fill in.

The other supported services will come soon.

Tested with several different repositories. Verified that the links worked
and all the sample values matched what I'd expect.


Description From Last Updated

'HttpResponse' imported but unused

reviewbotreviewbot

redefinition of unused 'HttpResponse' from line 6

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/service.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/static/rb/css/admin.less
        reviewboard/templates/admin/scmtools/repository/change_list.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/service.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/static/rb/css/admin.less
        reviewboard/templates/admin/scmtools/repository/change_list.html
    
    
  2. reviewboard/scmtools/admin.py (Diff revision 1)
     
     
    Show all issues
     'HttpResponse' imported but unused
    
  3. reviewboard/scmtools/admin.py (Diff revision 1)
     
     
    Show all issues
     redefinition of unused 'HttpResponse' from line 6
    
  4. 
      
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/service.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/static/rb/css/admin.less
        reviewboard/templates/admin/scmtools/repository/change_list.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/service.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/static/rb/css/admin.less
        reviewboard/templates/admin/scmtools/repository/change_list.html
    
    
  2. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/service.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/static/rb/css/admin.less
        reviewboard/templates/admin/scmtools/repository/change_list.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/service.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/static/rb/css/admin.less
        reviewboard/templates/admin/scmtools/repository/change_list.html
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (ced9251)