• 
      

    Only show the drag and drop indicator when the review request is editable.

    Review Request #6312 — Created Sept. 10, 2014 and submitted

    Information

    Review Board
    master
    f42bd5e...

    Reviewers

    Only show the drag and drop indicator when the review request is editable.

    Ran JS tests.

    Tried to drag-and-drop a file:
    as the creator of the review request - indicator appears
    while signed in as an admin - indicator appears
    while signed in as a different user (not admin) - indicator does not appear
    while not signed in - indicator does not appear

    Description From Last Updated

    We use 4-space indentation in all javascript and python files. You've indented everything an additional 2 spaces, which means you'll …

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
    2. 
        
    david
    1. 
        
    2. Show all issues

      We use 4-space indentation in all javascript and python files. You've indented everything an additional 2 spaces, which means you'll need to add 2 more.

    3. 
        
    dkus
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    dkus
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (22b17b1)