Summary

Fix usage of timedelta.total_seconds() in condensediffs.

Review Request #6304 — Created Sept. 8, 2014 and submitted Sept. 9, 2014, 12:01 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

15187c5...

Reviewers

Groups

reviewboard

People

Description

The total_seconds() method doesn't exist in Python 2.6, so we can't use it
yet. This change replaces it with the equivalent implementation (and moves us
over to using true division throughout this file as a side effect).

Testing Done

Condensed some diffs.

Issues

Description	From	Last Updated
Blank line before this.	chipx86	Sept. 8, 2014, 11:23 p.m.
Col: 73 E226 missing whitespace around arithmetic operator	reviewbot	Sept. 8, 2014, 10:57 p.m.
Col: 31 E226 missing whitespace around arithmetic operator	reviewbot	Sept. 8, 2014, 10:57 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/management/commands/condensediffs.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/management/commands/condensediffs.py

reviewboard/diffviewer/management/commands/condensediffs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 73
 E226 missing whitespace around arithmetic operator
```
reviewboard/diffviewer/management/commands/condensediffs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 31
 E226 missing whitespace around arithmetic operator
```

Description:: ~
The total\_seconds() method doesn't exist in Python 2.6, so we can't use it
~
The total_seconds() method doesn't exist in Python 2.6, so we can't use it
yet. This change replaces it with the equivalent implementation (and moves us
over to using true division throughout this file as a side effect).

Ship it!

reviewboard/diffviewer/management/commands/condensediffs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line before this.
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (46f92da)

~		The `total\_seconds()` method doesn't exist in Python 2.6, so we can't use it
	~	The `total_seconds()` method doesn't exist in Python 2.6, so we can't use it
		yet. This change replaces it with the equivalent implementation (and moves us
		over to using true division throughout this file as a side effect).