Summary

Fix posting with SVN.

Review Request #6285 — Created Sept. 2, 2014 and submitted Sept. 3, 2014, 1:54 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.6.x

Bugs

Depends On

Commit

86b6386...

Reviewers

Groups

rbtools

People

Description

The recent patch I accepted to reintroduce usage of find_server_repository_info
exposed a bug. The SVN implementation of this method hadn't been updated to
cope with recent changes to the attribute behavior of API objects, and so
trying to use repository.get('mirror_path') caused an AttributeError. We can
blame Python's dumb slots for that.

I've rewritten this part of the code to avoid the built-in get() method and
check hasattr instead.

Testing Done

Tried to post a change against my local devserver with an svn repository.
Before this change, I'd always get an AttributeError when trying to find the
repository. After, everything posts fine.

Issues

Description	From	Last Updated
Can't this still be written as one conditional?	chipx86	Sept. 2, 2014, 5:23 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py

rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can't this still be written as one conditional?
```

Commit:

2fceecf51d0c50b44c42334321465168b0b07598

86b63863ce80708963c80308455146305fb528ac

Diff:

Revision 2 (+3 -2)

Show changes

rbtools/clients/svn.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.6.x (d576ff7)

rbtools/clients/svn.py (Diff revision 1)