Summary

Add hostingsvcs.change_hostingserviceaccount perm to local-site admins.

Review Request #6281 — Created Aug. 28, 2014 and submitted Aug. 29, 2014, 4:42 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

0481c9f...

Reviewers

Groups

reviewboard

People

Description

On master, the unit tests for the remote repository resource are broken because
permission tests for the hostingsvcs.change_hostingserviceaccount permission
for local-site admins don't work. I'm not sure why this doesn't also break on
2.0.x, but either way this permission should be listed.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
'templatetags' imported but unused	reviewbot	Aug. 29, 2014, 4:14 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py



Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py

While you're here, can you also add reviews.delete_file and reviews.delete_screenshot?

Every one we add should also be in the unit test list in reviewboard/site/tests.py.

Commit:

ab872c8562da853ff14f5b5b813ee96401aa6c57

0481c9fd59ed44b1deffde17ea81359cc03ebc34

Diff:

Revision 2 (+9)

Show changes

	reviewboard/accounts/backends.py
	reviewboard/site/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/site/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/site/tests.py

reviewboard/site/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'templatetags' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (29bac1d)

reviewboard/site/tests.py (Diff revision 2)