• 
      

    Provide additional information for exception traceback e-mails.

    Review Request #6278 — Created Aug. 27, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    e4cba1a...

    Reviewers

    This adds new middleware to provide information on the username and
    e-mail address of the user who triggered the exception, if any. It also
    logs the Local Site name, if one is set.

    Added some code to trigger an exception on review requests. Accessed the
    review request page without a local site. Saw the USERNAME and USER_EMAIL
    variables were filled in.

    Accessed a review request on a local site and saw that the name was also shown.

    Description From Last Updated

    'django_reset' imported but unused

    reviewbotreviewbot

    'from settings_local import *' used; unable to detect undefined names

    reviewbotreviewbot

    'PIPELINE_CSS' imported but unused

    reviewbotreviewbot

    'PIPELINE_JS' imported but unused

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/settings.py
          reviewboard/admin/middleware.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/settings.py
          reviewboard/admin/middleware.py
      
      
    2. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'django_reset' imported but unused
      
    3. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'from settings_local import *' used; unable to detect undefined names
      
    4. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'PIPELINE_CSS' imported but unused
      
    5. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'PIPELINE_JS' imported but unused
      
    6. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (8c15530)