• 
      

    Fix accepting certificates for perforce repositories.

    Review Request #6273 — Created Aug. 26, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    b796d7b...

    Reviewers

    When we fixed accepting certificates for subversion repositories that used a
    username/password, we broke accepting certificates for perforce. The issue here
    is that the perforce implementation of accept_certificate() didn't have
    username and password parameters, and so passing them in caused it to
    TypeError.

    • Set up an SSL p4 server with a self-signed certificate and saw that I could
      once again add it to Review Board.
    • Ran unit tests.
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/scmtools/perforce.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/scmtools/perforce.py
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (fda8dd5)