• 
      

    Fix an annoying unicode comparison warning.

    Review Request #6254 — Created Aug. 21, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    fb95363...

    Reviewers

    If a given patch file isn't coercible to unicode, it would cause a
    UnicodeWarning when comparing it to the empty string. I've replaced this test
    with a truthy-test, which won't try to convert the arguments.

    Ran unit tests.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/diffviewer/diffutils.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/diffviewer/diffutils.py
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (ddaa5cb)