rbt post: checking repository info on server does not work anymore

Review Request #6233 — Created Aug. 16, 2014 and submitted

Information

RBTools
release-0.6.x
cc0bdd3...

Reviewers

since moving from post-review to rbt-post, find_server_repository_info is no more used.
It was very useful to check repository for clearcase SCM tool (and also implemented for SVN)

Fix also ClearCaseRepositoryInfo call from clearcase.py (3rd parameter is vobstag, I suppose "uuid" was an old copy paste from svn implementation

can post review request from any clearcase vob using rbt post 0.5.x

tested on release-0.5.x => rbt post works but breaks post-review
so my proposal would will be to import it in release-0.6.x and then find a way to backport it to 0.5.x (requires to make find_server_repository_info compatible with both post-review old ReviewboardSever class) and rbt-post (usage of api_root)

not able to test on svn side, so fix repositories loop without any test. If someone can check for SVN regression, would be great

Description From Last Updated

local variable 'changeSet' is assigned to but never used

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/commands/post.py
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/commands/post.py
        rbtools/clients/svn.py
    
    
  2. rbtools/clients/clearcase.py (Diff revision 1)
     
     
    Show all issues
     local variable 'changeSet' is assigned to but never used
    
    1. part of parent diff used for test. Not applicable with subject of this review

  3. 
      
DE
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/commands/post.py
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/commands/post.py
        rbtools/clients/svn.py
    
    
  2. 
      
DE
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/commands/post.py
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/commands/post.py
        rbtools/clients/svn.py
    
    
  2. 
      
david
  1. Looks good. I'm going to make some additional changes to include this call in other 'rbt' commands that use the repository info, and then push to release-0.6.x.

    The 0.5.x series is not being actively maintained, and we don't plan to release any more 0.5.x versions.

    1. support this for both post-review and rbt-post in 0.5.x seems too much work. Our teams should just prepare to move to rbt-post ;-)

      Thank you for this feedback

  2. 
      
DE
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.6.x (5defd0c)
david
  1. Ship It!

  2.