rbt post: checking repository info on server does not work anymore
Review Request #6233 — Created Aug. 16, 2014 and submitted
since moving from post-review to rbt-post, find_server_repository_info is no more used.
It was very useful to check repository for clearcase SCM tool (and also implemented for SVN)Fix also ClearCaseRepositoryInfo call from clearcase.py (3rd parameter is vobstag, I suppose "uuid" was an old copy paste from svn implementation
can post review request from any clearcase vob using rbt post 0.5.x
tested on release-0.5.x => rbt post works but breaks post-review
so my proposal would will be to import it in release-0.6.x and then find a way to backport it to 0.5.x (requires to make find_server_repository_info compatible with both post-review old ReviewboardSever class) and rbt-post (usage of api_root)not able to test on svn side, so fix repositories loop without any test. If someone can check for SVN regression, would be great
Description | From | Last Updated |
---|---|---|
local variable 'changeSet' is assigned to but never used |
reviewbot |
- Change Summary:
-
sync with latest release-0.6.x (f6c941d)
- Commit:
-
cc0bdd3c82d2f721f1fa44ac03a7cf47d9d7449b
-
Tool: Pyflakes Processed Files: rbtools/clients/clearcase.py rbtools/commands/post.py rbtools/clients/svn.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/clearcase.py rbtools/commands/post.py rbtools/clients/svn.py
-
Tool: Pyflakes Processed Files: rbtools/clients/clearcase.py rbtools/commands/post.py rbtools/clients/svn.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/clearcase.py rbtools/commands/post.py rbtools/clients/svn.py