Summary

Fix the revision selector on IE 9/10/11.

Review Request #6230 — Created Aug. 14, 2014 and submitted Aug. 16, 2014, 12:43 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

3373

Depends On

Commit

3b359dd...

Reviewers

Groups

reviewboard

People

Description

The code for the revision selector used a property for the page scroll
offset that wasn't standard across all browsers. That property is just
an alias for the actual standard property, pageXOffset. Switching to
this fixes the revision slider on IE.

Testing Done

Tested in IE 9, 10 and 11 compatibility modes, using IE11. I was able to
change the slider however I liked, and the page updated.

Tested in Chrome and Firefox.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js

Can you also test in chrome and firefox?

chipx86 Aug. 14, 2014, 6:30 p.m.

Sorry, left that out, but I did test. I had all 3 browsers open while doing the IE work.

Testing Done:: Tested in IE 9, 10 and 11 compatibility modes, using IE11. I was able to
change the slider however I liked, and the page updated.
+
+
Tested in Chrome and Firefox.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (da06e02)

		Tested in IE 9, 10 and 11 compatibility modes, using IE11. I was able to
		change the slider however I liked, and the page updated.
	+
	+	Tested in Chrome and Firefox.