Fix posting changes with an empty commit ID.

Review Request #6219 — Created Aug. 12, 2014 and submitted

Information

Review Board
release-2.0.x
8112e73...

Reviewers

Posting with an empty commit ID (a blank string) resulted in the blank
string being set for the review request or draft. This resulted in
conflicts, since a blank string is considered a valid value for unique
constraints. We now normalize it to None in this case.

Unit tests pass.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_review_request_draft.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/webapi/resources/review_request.py
        reviewboard/webapi/tests/test_review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_review_request_draft.py
        reviewboard/webapi/resources/review_request_draft.py
        reviewboard/webapi/resources/review_request.py
        reviewboard/webapi/tests/test_review_request.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (98f4584)
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (98f4584)