• 
      

    Fixed subvertpy "Assertion `svn_uri_is_canonical(child_uri, ((void *)0))' failed"

    Review Request #6215 — Created Aug. 11, 2014 and submitted — Latest diff uploaded

    Information

    Review Board
    release-2.0.x
    e5af89b...

    Reviewers

    There is an error in list function of subvertpy Client when path parameter ends with trailing slash.
    This error also displays when running tests.
    output:
    python: /build/buildd/subversion-1.8.8/subversion/libsvn_subr/dirent_uri.c:1499: uri_skip_ancestor: Assertion `svn_uri_is_canonical(child_uri, ((void *)0))' failed.
    Subvertpy version is 0.9.1
    Presented changes cut trailing slash and fixes error.

    All tests:
    1483 tests run in 121.9 seconds.
    45 skipped (1438 tests passed)

    **./reviewboard/manage.py test -- reviewboard.scmtools.tests:SubvertpyTests **
    Testing SVN (subvertpy) parsing SVN diff with binary file ... passed
    Testing SVN keyword collapsing ... passed
    Testing parsing SVN diff with added empty file ... passed
    Testing parsing SVN diff with deleted empty file ... passed
    Testing SVN (subvertpy) parsing diff with spaces in filenames ... passed
    Testing SVN (subvertpy) get_branches ... passed
    Testing SVN (subvertpy) get_change ... passed
    Testing SVN (subvertpy) get_commits ... passed
    Testing SVN (subvertpy) get_commits with branch ... passed
    Testing SVN (subvertpy) get_file ... passed
    Testing SVN (subvertpy) with basic SVNTool API ... passed
    Testing SVN (subvertpy) parsing diff with keywords ... passed
    Testing correct concat svn repopath and path ... passed
    Testing SVN (subvertpy) revision number parsing ... passed
    Testing SVN (subvertpy) with a SSH-backed Subversion repository ... skipped
    Testing SVN (subvertpy) with a SSH-backed Subversion repository with a LocalSite ... skipped
    Testing SVN (subvertpy) parsing SVN 1.6 diff with property changes ... passed
    Testing SVN (subvertpy) parsing SVN 1.7+ diff with property changes ... passed
    Testing SVN (subvertpy) parsing diff with unicode characters ... passed
    Testing SVN (subvertpy) parsing diff with unterminated keywords ... passed
    Testing SVN (subvertpy) with UTF-8 files with keywords ... passed