Summary

Add a function to get raw base64 content on Base64Fields.

Review Request #6209 — Created Aug. 7, 2014 and submitted Aug. 12, 2014, 10:24 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.8.x

Bugs

Depends On

Blocks

6208

Commit

0710dc3...

Reviewers

Groups

djblets

People

Description

Base64Field now provides a get_<fieldname>_base64() function that will

return the actual Base64 content, rather than the decoded content.

Testing Done

Made use of this in another change. Verified that I got the proper content.

Issues

Description	From	Last Updated
Can you reorder these a bit? super(Base64field, self).contribute_to_class(cls, name) setattr(cls, self.name, Base64FieldCreator(self)) def get_base64(model_instance): return self.value_to_string(model_instance) setattr(cls, 'get_%s_base64' % self.name, …	david	Aug. 7, 2014, 11:52 p.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/db/fields.py



Tool: Pyflakes
Processed Files:
    djblets/db/fields.py

djblets/db/fields.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you reorder these a bit?

super(Base64field, self).contribute_to_class(cls, name)

setattr(cls, self.name, Base64FieldCreator(self))

def get_base64(model_instance):
    return self.value_to_string(model_instance)
setattr(cls, 'get_%s_base64' % self.name, get_base64)

Change Summary:


The get_*_base64 now just returns the encoded data stored as part of the model instance, instead of re-encoding.
Simplified the code by removing the function and using a lambda.

Commit:

13ce744ac64afb59ada7456af34bc3b9e98c1ecd

0710dc38af06c232cd5af483f9044a9695bd3a10

Diff:

Revision 2 (+3)

Show changes

djblets/db/fields.py

Tool: Pyflakes
Processed Files:
    djblets/db/fields.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/db/fields.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.8.x (492c7f2)