• 
      

    Fix the file sizes and percentages shown for condensediffs.

    Review Request #6208 — Created Aug. 7, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    afc5bb7...

    Reviewers

    When running condensediffs, the decoded diff content was being used for
    the byte counts, rather than the stored base64 content. This gave an
    inaccurate result for the total number of bytes and the bytes saved.

    The percentage was also wrong, due to a bad calculation. Now it shows an
    accurate savings as a percentage, and also shows up to 2 decimal places.

    Ran a condensediffs and saw the proper counts and percentage. It was way
    off before, for the database I was using.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/diffviewer/management/commands/condensediffs.py
          reviewboard/diffviewer/managers.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/diffviewer/management/commands/condensediffs.py
          reviewboard/diffviewer/managers.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (a7ca4f9)