Don't cache commits as aggressively if 'branch' and 'start' aren't provided.
Review Request #6201 — Created Aug. 5, 2014 and submitted
The code for getting the list of commits would cache for one day, but we only
want to do that if the branch and start commit are explicitly specified. If
not, we should still cache but for a much shorter period (to avoid the list
being up to one day out of date). This change fixes that.
- Tested svn post-commit list.
- Ran unit tests.
-
Looks fine. Something we should consider though is that people may commit and then try to immediately post through the web UI, in which case they'll need to wait. I don't have a great solution here, except that we could potentially enhance this code later to look at HEAD for the branch and include that revision in the cache key.
Tool: Pyflakes Processed Files: reviewboard/scmtools/models.py Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/models.py