Summary

Add "select" control to inlineEditor (WIP, RFC)

Review Request #6197 — Created Aug. 5, 2014 and discarded Aug. 29, 2014, 6:25 p.m.

Information

Owner

ahills

Repository

Djblets

Branch

master

Bugs

Depends On

Blocks

6198

Commit

3eacb42...

Reviewers

Groups

djblets

People

Description

Somewhat messy, but tested, addition of drop-down and combo boxes. If selectOptions is set, multiline determines whether the multiple property is set. Hijacked some of the options, which seems messy; please advise on preferred methods. (I am not a JavaScript programmer.)

Testing Done

In a Review Board extension, created fields with options CSS class. For multiline, added multiple class. They work as expected.

Tool: PEP8 Style Checker
Ignored Files:
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js



Tool: Pyflakes
Ignored Files:
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js

Change Summary:: Take advantage of markdown
Description:: ~
Somewhat messy, but tested, addition of drop-down and combo boxes. If selectOptions is set, multiline determines whether the "multiple" property is set. Hijacked some of the options, which seems messy; please advise on preferred methods. (I am not a JavaScript programmer.)
~
Somewhat messy, but tested, addition of drop-down and combo boxes. If selectOptions is set, multiline determines whether the multiple property is set. Hijacked some of the options, which seems messy; please advise on preferred methods. (I am not a JavaScript programmer.)
Testing Done:: ~
In a Review Board extension, created fields with "options" CSS class. For multiline, added "multiple" class. They work as expected.
~
In a Review Board extension, created fields with options CSS class. For multiline, added multiple class. They work as expected.

Change Summary:

Fix appearance of multioption box

Commit:

8a90a6909f2e4ae71ff225da49895eb09bbe346d

3eacb42d7635a95efc3707241e59a7cb2f6c4bd6

Diff:

Revision 2 (+32 -4)

Show changes

djblets/static/djblets/js/jquery.gravy.inlineEditor.js

Tool: PEP8 Style Checker
Ignored Files:
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js



Tool: Pyflakes
Ignored Files:
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js

I'm kind of wary about adding such a different mode to what is already an incredibly complicated control (although it is a surprisingly small amount of code). Did you consider making a completely new control instead?

ahills Aug. 29, 2014, 6:25 p.m.

Yeah, I think I'll have to learn how to do that. I'm using this implementation, and it's pretty messy. I'm going to discard this request.

chipx86 Aug. 29, 2014, 6:25 p.m.

I think we may have had some discussion over e-mail involving this, but for what it's worth, I think we shouldn't lump all the editable fields for a review request behind an inline editor. We should probably just embed a select control directly when the field is editable, rather than wrapping it.

The inline editor is great when you want to have "begin editing," "cancel editing," and "save edited content" actions, which works well for text. A select field is much simpler.

ahills Aug. 29, 2014, 6:26 p.m.

Agreed. This was the shortest route to shoehorning a feature in when I needed it quickly, but it's not a good solution.

Status:: Discarded