• 
      

    Fix handling of deleted files in submitted perforce changelists.

    Review Request #6191 — Created Aug. 1, 2014 and submitted

    Information

    RBTools
    release-0.6.x
    ec78f9e...

    Reviewers

    When we fetch the list of affected files in a given changelist, perforce
    reports deleted files with a revision number. That revision corresponds to the
    deleted version of the file, and p4 print will just return empty. This is
    similar to edits, where the revision is actually the post-edited revision
    rather than the pre-edited version, and we need to decrement the revision.

    • Ran through some p4 deletes.
    • Ran unit tests.
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/perforce.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/perforce.py
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.6.x (d5d59ba)