• 
      

    Fixed extra whitespace issues in review request editors.

    Review Request #6178 — Created July 31, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    4c2a3c2...

    Reviewers

    The file attachment thumbnails and editors on the right-hand side
    of review requests had bugs where they would show extra leading
    whitespace on edit. This happened because the HTML had whitespace for
    formatting, which ended up in the edit field.

    The templates for these fields are now compressed down to not have any
    extra whitespace. This makes the templates less readable, but ensures
    that the only whitespace in there is whitespace provided by the value
    server-side.

    Clicked the fields. No longer saw any leading whitespace in the edit field.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
          reviewboard/templates/reviews/review_request_box.html
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
          reviewboard/templates/reviews/review_request_box.html
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (9703271)