• 
      

    Allow greater control over inline editor buttons and rendering.

    Review Request #6173 — Created July 31, 2014 and submitted

    Information

    Djblets
    release-0.8.x
    a786428...

    Reviewers

    The buttons element is no longer always a <div>. If it's a multi-line
    editor, it will appear as a <div/>, but if it's a single-line editor, it
    will appear as a <span>. This is preferred over hard-coding a
    display: inline style on the element, and will have the same effect by
    default. Custom CSS can then override it to have whatever display style
    is appropriate.

    There are also cases where a caller may need to set some properties on
    an element before actually showing the editor and triggering the layout
    code. For example, an element may need to be set that would impact the
    positioning of the buttons or some other aspect of the editor.

    To handle this, there's now a beginEditPreShow event that callers can
    listen to. This is displayed immediately before the editor is shown.

    Saw buttons appear inline, as they did before, on single-line editors.

    Set some CSS to force buttons on the next line. That worked, and didn't
    before due to the inline style.

    Set some CSS on the element before the editor was shown.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
    2. 
        
    chipx86
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (33bb7bc)