Pass SVN credentials when accepting a self-signed certificate.

Review Request #6171 — Created July 30, 2014 and submitted

Information

Review Board
release-2.0.x
6e5b07f...

Reviewers

When accepting a self-signed certificate, the SVN credentials weren't
being passed. This could result in a breakage for installs that blocked
anonymous access.

accept_certificate() is now set up to take the credentials, which the
form passes. Those are then passed to build_client for SVNTool.

This fixed some issues I was able to hit with adding repositories with a
self-signed cert and that required authentication.

While here, I also fixed a missing space between two sentences in an
error message that I came across when setting up an environment for
this.

Accepted a self-signed cert and saw it immediately add the repository,
passing a username and password.

Prior to this, with the configuration I created, I would see it fail on
occasion after attempting to connect again after the read-only attempt.
I don't know if this was some bug or some connection limiting on my SVN
server, but this solved it, and is more correct anyway.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/forms.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/forms.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (44c757b)
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (44c757b)