• 
      

    Read System Arguments after .reviewboardrc

    Review Request #6166 — Created July 29, 2014 and discarded

    Information

    RBTools
    master

    Reviewers

    In my repositories I have added functionality to .reviewboardrc to allow for a command prompt menu instead of having a long list of parameters each time you commit. This worked well with post-review but since we upgraded to rbt post we encountered some issues. The way it works is we inject systems argument after asking a few basic questions (summary, description, and group of reviewers). I propose to reload the system arguments after the reviewboardrc allowing more flexibility to what people can add in .reviewboardrc after the file has been read/executed instead of just passing the argv.

    
     
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/commands/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/__init__.py
      
      
    2. 
        
    david
    1. I'm a little confused about how this works. Did you make a change in load_config() that adds things to sys.argv?

    2. 
        
    MC
    Review request changed
    Status:
    Discarded