Summary

Added validation for API policies.

Review Request #6164 — Created July 29, 2014 and submitted July 29, 2014, 5:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

a53f02f...

Reviewers

Groups

reviewboard

People

Description

This introduces WebAPIToken.validate_policy, which will look through a
policy definition and try to find any errors. It will check for required
data, data in invalid formats, policy IDs validity, and more.

This is called when posting or updating a policy, and the error will be
returned in the API error.

Testing Done

Unit tests pass.

Tested several bits of validation manually with my policy editor change.

Issues

Description	From	Last Updated
undefined name '_'	reviewbot	Aug. 6, 2014, 8:09 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_api_policy.py
    reviewboard/webapi/models.py
    reviewboard/webapi/resources/api_token.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_api_policy.py
    reviewboard/webapi/models.py
    reviewboard/webapi/resources/api_token.py

reviewboard/webapi/resources/api_token.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name '_'
```

Change Summary:

Fixed a missing import.

Commit:

e976e09ec290c0e669d4af8a60de6e0946a183ec

a53f02fb36918c5008fcbded226921ce513a9daa

Diff:

Revision 2 (+453 -6)

Show changes

	reviewboard/webapi/models.py
	reviewboard/webapi/resources/api_token.py
	reviewboard/webapi/tests/test_api_policy.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_api_policy.py
    reviewboard/webapi/models.py
    reviewboard/webapi/resources/api_token.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_api_policy.py
    reviewboard/webapi/models.py
    reviewboard/webapi/resources/api_token.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (67256ba)