• 
      

    Fix allowing admins to reopen discarded review requests.

    Review Request #6144 — Created July 25, 2014 and submitted

    Information

    Review Board
    release-1.7.x
    5a92c7c...

    Reviewers

    Due to a bad conditional, it wasn't possible for an admin (or user with
    the appropriate permissions) to reopen a discarded review request. This
    worked for submitted review requests, but not discarded.

    The conditional now includes the permission check.

    Looked at a discarded review request from another user. Saw the "Reopen" button.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/templates/reviews/review_header.html
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/templates/reviews/review_header.html
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.7.x (d513ba1)