• 
      

    Show errors when trying to discard drafts.

    Review Request #6137 — Created July 23, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    3799afa...

    Reviewers

    The "Discard Draft" action would fail silently if something went wrong (for
    example, if the server was inaccessible or the user was no longer logged in).
    This change does some trivial plumbing to show the user an error in this case
    (in the same way that we show other highly unexpected errors).

    Loaded the page, killed my devserver, and tried to discard a draft. Saw an
    alert that said "HTTP 0 error", which is at least better than nothing.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    VO
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (8ac72ed)