• 
      

    Fix 'ctrl+s' in inlineEditors that use CodeMirror.

    Review Request #6133 — Created July 22, 2014 and submitted

    Information

    Djblets
    release-0.8.x
    452616b...

    Reviewers

    inlineEditor has two functions that save the contents: save and submit. Of
    these two, save is really just meant to be an internal helper, and submit
    is the one that does a lot of the necessary cleanup.

    The handler for 'ctrl+s' was calling save, which caused the editor box to
    disappear. Changing it to submit makes everything work correctly.

    Opened an inline editor that used CodeMirror and hit ctrl+s. Saw the input box
    disappear and be replaced with the rendered contents.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (2da460a)