Added "My Review Requests" link to base navigation bar

 






 

 


  Review Request #613
  —
  Created Oct. 25, 2008 and submitted

 


















 

  

   Information

  





 
 

  noahmiller
 









 
 

  Review Board SVN (deprecated)
 









 
 

  
 









 
 

  503
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
I added "My Review Requests" link to base navigation bar, which links to /users/<username>/ for the current authenticated user.  This makes it easy to find your own review requests, rather than having to search on your username or scroll through a long list of "submitters".  I also added this link to the base iPhone page.

This link does not appear for non-authenticated users.

 








  


 
 

  
Tested with Review Board r1554 in Firefox 3 (OS X).
Tested with both authenticated and anonymous users.  Tested on dashboard/, iphone/, and various other pages.
Ran unit tests, and created a new test (ViewTests.testDashboard5).

 







 









 





  







 

  
Screenshots

  
 



 









 






  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I'm leaning toward wanting this to be an item in the Dashboard, as the Dashboard is meant to be a "my stuff/stuff I'm interested in" area.

Curious what others think about this.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      That makes sense.  That would also prevent the top navigation bar from getting too wide.  I've posted a sample screenshot.  Let me know if you'd like me to implement it, or if you have other suggestions.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I like this.

Come to think of it, why isn't "All Review Requests" in that box, too?
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      You might be an anonymous user wishing to look at review requests.
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      Any update on this?
      
 
      

      5. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 NO





   

   

  

 



 















 



 

  

   





 NO





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  















  

   

    Testing Done:
   

   

    
     
Tested with Review Board r1554 in Firefox 3 (OS X).
 ~   Tested with both authenticated and anonymous users.  Tested on dashboard/, iphone/, and various other pages.
   ~ Tested with both authenticated and anonymous users.  Tested on dashboard/, iphone/, and various other pages.
   + Ran unit tests, and created a new test (ViewTests.testDashboard5).

   

  












  

 
















 





 

  

   





 IS





   

   





  

 



 

  


   

   

    
 
israel.santiago


    
   


  

  

  



    




  1. 
 
    
  
    
   
    testing.......
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I'm pretty happy with it now :) Thanks for the work! Committed as r1908.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.